Inertia web settings page #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobheadxi
changed the title
bobheadxi
reviewed
Jun 29, 2018
| </TableHeader> | ||
|
|
||
| <TableBody> | ||
| <TableRow> |
There was a problem hiding this comment.
Sure you can list out the divs like this, but think about what the API returns to the web app:
https://github.com/ubclaunchpad/inertia/blob/master/common/types.go#L4
type DeploymentStatus struct {
InertiaVersion string `json:"version"`
Branch string `json:"branch"`
CommitHash string `json:"commit_hash"`
CommitMessage string `json:"commit_message"`
BuildType string `json:"build_type"`
Containers []string `json:"containers"`
BuildContainerActive bool `json:"build_active"`
}maybe there's a cleaner way to generate this table?
There was a problem hiding this comment.
right the html is on the redundant side as i was trying to get a more consistent look. I'll get back to this
| @@ -232,6 +233,7 @@ class MainWrapper extends React.Component { | |||
|
|
|||
| <Link to={`${this.props.match.url}/dashboard`}>Click to go to Dashboard</Link> | |||
| <Link to={`${this.props.match.url}/containers`}>Click to go to Containers</Link> | |||
| <Link to={`${this.props.match.url}/settings`}>Click to go to Settings</Link> | |||
| const IconHeader = ({ title, type }) => ( | ||
| <div className="iconheader"> | ||
| const IconHeader = ({ title, type, style }) => ( | ||
| <div className="iconheader" style={style}> |
Codecov Report
@@ Coverage Diff @@
## master #289 +/- ##
=======================================
Coverage 38.59% 38.59%
=======================================
Files 49 49
Lines 3084 3084
=======================================
Hits 1190 1190
Misses 1744 1744
Partials 150 150Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Ticket(s): Closes #247
👷 Changes
two new mock button added.
🔦 Testing Instructions
point to http://localhost:7900/web/#/home/settings