Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image pruning #295

Merged
merged 15 commits into from
Jul 13, 2018
Merged

Image pruning #295

merged 15 commits into from
Jul 13, 2018

Conversation

bobheadxi
Copy link
Member

🎟️ Ticket(s): Closes #158

👷 Changes

Adds automated image pruning during builds as well as an endpoint + CLI command to do this manually

🔦 Testing Instructions

Build some images on remote, check docker image ls

@bobheadxi bobheadxi added the pr: wip in progress but seeking feedback label Jul 2, 2018
@bobheadxi bobheadxi requested a review from a team July 2, 2018 18:06
@bobheadxi bobheadxi requested a review from bwdmonkey July 4, 2018 02:01
@bobheadxi bobheadxi added pr: finalized needs review and final approval and removed pr: wip in progress but seeking feedback labels Jul 9, 2018
@coveralls
Copy link

coveralls commented Jul 11, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 1130

  • 58 of 152 (38.16%) changed or added relevant lines in 9 files are covered.
  • 126 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.5%) to 41.525%
Changes Missing Coverage Covered Lines Changed/Added Lines %
client/client.go 5 6 83.33%
daemon/inertiad/daemon.go 0 1 0.0%
cmd/provision.go 0 2 0.0%
daemon/inertiad/project/deployment.go 8 14 57.14%
daemon/inertiad/build/builder.go 2 11 18.18%
daemon/inertiad/containers/containers.go 43 54 79.63%
daemon/inertiad/up.go 0 14 0.0%
daemon/inertiad/prune.go 0 24 0.0%
cmd/deploy.go 0 26 0.0%
Files with Coverage Reduction New Missed Lines %
daemon/inertiad/project/deployment.go 1 50.0%
cmd/users.go 6 0.0%
cmd/provision.go 14 13.39%
client/client.go 31 77.4%
cmd/deploy.go 74 3.26%
Totals Coverage Status
Change from base Build 1108: -0.5%
Covered Lines: 1617
Relevant Lines: 3894
💛 - Coveralls

@bobheadxi bobheadxi merged commit 583607f into master Jul 13, 2018
@bobheadxi bobheadxi deleted the daemon/#158-image-pruning branch July 13, 2018 07:19
PiggySpeed added a commit that referenced this pull request Jul 14, 2018
@PiggySpeed
Squashed commit of the following:
f96e6dd 
commit 9fd7258
Author: Robert Lin <robertlin1@gmail.com>
Date:   Sat Jul 14 13:04:18 2018 -0700

    Clean up tooltips for consistency (#316)

commit 79e6d53
Author: Robert Lin <robertlin1@gmail.com>
Date:   Sat Jul 14 12:14:24 2018 -0700

    Rename codecov.yml

commit eed6172
Author: Robert Lin <robertlin1@gmail.com>
Date:   Sat Jul 14 12:00:53 2018 -0700

    Switch from go-bindata to fileb0x (#318)

commit b0bba7b
Author: Robert Lin <robertlin1@gmail.com>
Date:   Sat Jul 14 11:47:02 2018 -0700

    Add coverage configuration (#319)

commit f5e6933
Author: Robert Lin <robertlin1@gmail.com>
Date:   Sat Jul 14 10:18:46 2018 -0700

    Report coverage to codecov.io (#317)

commit 583607f
Merge: 696e3ff 7d62818
Author: Robert Lin <robertlin1@gmail.com>
Date:   Fri Jul 13 00:18:59 2018 -0700

    Merge pull request #295 from ubclaunchpad/daemon/#158-image-pruning

    Image pruning

commit 7d62818
Author: Robert Lin <robertlin1@gmail.com>
Date:   Thu Jul 12 20:53:22 2018 -0700

    Add basic container ops tests

commit 1c9af26
Author: Robert Lin <robertlin1@gmail.com>
Date:   Thu Jul 12 20:42:51 2018 -0700

    Add input walkthrough tests

commit 491656a
Author: Robert Lin <robertlin1@gmail.com>
Date:   Thu Jul 12 20:21:45 2018 -0700

    Add simple prune request test

commit 84b26bb
Author: Robert Lin <robertlin1@gmail.com>
Date:   Thu Jul 12 20:20:50 2018 -0700

    Add simple User tests

commit cb733dc
Author: Robert Lin <robertlin1@gmail.com>
Date:   Thu Jul 12 20:13:38 2018 -0700

    Add LogsWebSocket test

commit 696e3ff
Merge: 49bd5e2 edf5de2
Author: Robert Lin <robertlin1@gmail.com>
Date:   Tue Jul 10 21:05:14 2018 -0700

    Merge pull request #314 from ubclaunchpad/client/#260-inertia-remove

    inertia [remote] remove

commit edf5de2
Author: Tom Lee <win981026@gmail.com>
Date:   Tue Jul 10 20:31:59 2018 -0700

    "process feedback"

commit fdec8ad
Author: Robert Lin <robertlin1@gmail.com>
Date:   Tue Jul 10 20:31:27 2018 -0700

    Reorder prune operation

commit 83e9c43
Author: Tom Lee <win981026@gmail.com>
Date:   Tue Jul 10 20:12:36 2018 -0700

    Fix usages of MinimumNArgs to ExactArgs.
    - `inertia [proj] user reset` was unnecessary requiring argument when not used.

commit a0bd5c8
Author: Tom Lee <win981026@gmail.com>
Date:   Tue Jul 10 20:10:15 2018 -0700

    A `inertia [proj] remove` command to nuke everything inertia-related from VPS.
    - Use the `daemon-down` script
    - Clear `~/inertia` directory on the daemon

commit 49bd5e2
Author: Robert Lin <robertlin1@gmail.com>
Date:   Tue Jul 10 19:54:15 2018 -0700

    Add missing newlines (#313)

commit f7513a3
Merge: 0e68c84 5b10c12
Author: Robert Lin <robertlin1@gmail.com>
Date:   Tue Jul 10 19:29:41 2018 -0700

    Merge branch 'master' into daemon/#158-image-pruning

commit 5b10c12
Merge: 14cf119 c5fbe7a
Author: Robert Lin <robertlin1@gmail.com>
Date:   Mon Jul 9 22:45:51 2018 -0700

    Merge pull request #301 from ubclaunchpad/daemon/#133-webhooks

    Webhook rework and support for GitLab

commit c5fbe7a
Author: brian-nguyen <briannguyen992@gmail.com>
Date:   Mon Jul 9 21:58:59 2018 -0700

    Revert "Fix formatting of FPrintf statements"

    This reverts commit e9f82dd.

commit 1cd7d9c
Author: brian-nguyen <briannguyen992@gmail.com>
Date:   Mon Jul 9 21:51:26 2018 -0700

    Remove vestigial dependency

commit e9f82dd
Author: brian-nguyen <briannguyen992@gmail.com>
Date:   Mon Jul 9 21:38:13 2018 -0700

    Fix formatting of FPrintf statements

commit 35c4c6f
Author: brian-nguyen <briannguyen992@gmail.com>
Date:   Sun Jul 8 23:17:57 2018 -0700

    Pass os.Stdout directly rather than via intermediate var

commit 6bc3212
Author: brian-nguyen <briannguyen992@gmail.com>
Date:   Sun Jul 8 23:17:19 2018 -0700

    Remove go-github dependency

commit 0e68c84
Author: Robert Lin <robertlin1@gmail.com>
Date:   Sun Jul 8 20:02:27 2018 -0700

    Call prune during build, improve feedback of missing data manager

commit 8108d7b
Author: Robert Lin <robertlin1@gmail.com>
Date:   Sun Jul 8 19:29:08 2018 -0700

    Fix minor assignment error

commit c1ee1e7
Author: Robert Lin <robertlin1@gmail.com>
Date:   Sun Jul 8 19:25:55 2018 -0700

    Add pruneAll option, for use with the prune endpoint

commit 7e0c93f
Author: Robert Lin <robertlin1@gmail.com>
Date:   Sun Jul 8 19:25:26 2018 -0700

    Add miscellaneous tests

commit 14cf119
Author: Correy Lim <correylim@gmail.com>
Date:   Sat Jul 7 17:25:42 2018 -0700

    Add READMEs for package local and provision (#306)

commit 7a16542
Author: brian-nguyen <briannguyen992@gmail.com>
Date:   Sat Jul 7 16:24:52 2018 -0700

    Fix webhook print format

commit cb13762
Author: brian-nguyen <briannguyen992@gmail.com>
Date:   Sat Jul 7 16:08:51 2018 -0700

    Direct webhook handler's output to stdout

commit 48c2bc9
Author: Anna Situ <annasitu1@gmail.com>
Date:   Sat Jul 7 15:51:45 2018 -0700

    Added UBC logo svg (#304)

commit 8b2d512
Author: brian-nguyen <briannguyen992@gmail.com>
Date:   Sat Jul 7 15:43:16 2018 -0700

    Add gitlab support to webhook handler

commit 51dee15
Author: brian-nguyen <briannguyen992@gmail.com>
Date:   Sat Jul 7 15:08:51 2018 -0700

    Remove unnecessary print statements

commit d2a1cd2
Author: brian-nguyen <briannguyen992@gmail.com>
Date:   Sat Jul 7 14:57:46 2018 -0700

    Integrate new webhook pkg

commit 74080ea
Author: brian-nguyen <briannguyen992@gmail.com>
Date:   Sat Jul 7 14:45:25 2018 -0700

    Rework JSON decoding to fix inteface issue

commit e20ab69
Author: brian-nguyen <briannguyen992@gmail.com>
Date:   Sat Jul 7 12:31:09 2018 -0700

    Conform to godoc spec

commit 3bca676
Author: brian-nguyen <briannguyen992@gmail.com>
Date:   Sat Jul 7 11:26:22 2018 -0700

    Export the main webhook parse method

commit 544168d
Author: brian-nguyen <briannguyen992@gmail.com>
Date:   Sat Jul 7 11:10:36 2018 -0700

    Add check for supported Github events

commit 42a4313
Author: brian-nguyen <briannguyen992@gmail.com>
Date:   Sat Jul 7 00:49:38 2018 -0700

    Add generic webhook interface and Github event handler

commit 1864275
Author: brian-nguyen <briannguyen992@gmail.com>
Date:   Fri Jul 6 23:44:26 2018 -0700

    Add basic detection for three major git hosts

commit 0853077
Author: Robert Lin <robertlin1@gmail.com>
Date:   Mon Jul 2 11:04:30 2018 -0700

    Add 'prune' endpoint and CLI command

commit 357cb40
Merge: 0a8b005 ab144d7
Author: Robert Lin <robertlin1@gmail.com>
Date:   Mon Jul 2 10:52:40 2018 -0700

    Merge branch 'master' into daemon/#158-image-pruning

commit 0a8b005
Author: Robert Lin <robertlin1@gmail.com>
Date:   Sun Jul 1 15:01:57 2018 -0700

    Set stopper on builder constructor

commit efe4eb1
Author: Robert Lin <robertlin1@gmail.com>
Date:   Sun Jul 1 14:31:23 2018 -0700

    Add image pruning with filter, move containerStopper into Builder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PiggySpeed PiggySpeed Awaiting requested review from PiggySpeed

@bwdmonkey bwdmonkey Awaiting requested review from bwdmonkey

Assignees
No one assigned
Labels
pr: finalized needs review and final approval
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bobheadxi @coveralls