Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct invalid references and add more detail to guide #299

Merged
merged 1 commit into from
Jul 4, 2018
Merged

Correct invalid references and add more detail to guide #299

merged 1 commit into from
Jul 4, 2018

Conversation

bobheadxi
Copy link
Member

🎟️ Ticket(s): Closes #298

👷 Changes

  • 'client/bootstrap' is now 'client/scripts'
  • add note that the docker daemon should be online
  • add instructions for setting up GOPATH and GOBIN

🔦 Testing Instructions

just read it

@bobheadxi
Correct invalid references and add more detail to guide
8bc290d 
* 'client/bootstrap' is now 'client/scripts'
* add note that the docker daemon should be online
* add instructions for setting up GOPATH and GOBIN
@bobheadxi bobheadxi added pr: finalized needs review and final approval merge: squash labels Jul 4, 2018
@bobheadxi bobheadxi requested a review from bwdmonkey July 4, 2018 05:43
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1046

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 41.783%
Totals Coverage Status
Change from base Build 1035: 0.0%
Covered Lines: 1434
Relevant Lines: 3432
💛 - Coveralls

bwdmonkey
bwdmonkey approved these changes Jul 4, 2018
View reviewed changes
Copy link
Member

@bwdmonkey bwdmonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bobheadxi bobheadxi merged commit 0c4136e into master Jul 4, 2018
@bobheadxi bobheadxi deleted the docs/#298-contributing branch July 4, 2018 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwdmonkey bwdmonkey bwdmonkey approved these changes

@PiggySpeed PiggySpeed Awaiting requested review from PiggySpeed

Assignees
No one assigned
Labels
pr: finalized needs review and final approval
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bobheadxi @coveralls @bwdmonkey