Check for docker-compose on init #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chadlagore
approved these changes
Jan 22, 2018
chadlagore
reviewed
Jan 22, 2018
| assert.Equal(t, nil, CheckForGit(inertia)) | ||
| } | ||
|
|
||
| func TestCheckForDockerCompose(t *testing.T) { |
There was a problem hiding this comment.
We need containers for this type of testing 😅
There was a problem hiding this comment.
Maybe, but a container would probably be a bit overkill for this because all it does is check for the presence of the docker-compose.yml file
There was a problem hiding this comment.
Its more this contamination of the developers file system during tests. Say someone creates a docker-compose.yml file in this repo one day, then they run this test. The test failing is the best we can hope for, the worst is that it nukes their file.
|
Most will stil have the standard |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⌛ Status: ready
🎟️ Ticket(s): Close #36 Warn if
inertia initin non-docker-compose project👷 Changes
inertia init🔦 Testing Instructions