Deployment Logs #93
Merged
Deployment Logs #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobheadxi
requested review from
rogermyang,
PiggySpeed,
chadlagore and
arjansandhu
chadlagore
approved these changes
Feb 24, 2018
| type DaemonRequest struct { | ||
| Stream bool `json:"stream"` | ||
| Repo string `json:"repo,omitempty"` | ||
| Container string `json:"container,omitempty"` |
There was a problem hiding this comment.
As handy as this JSON language is, it feels like a smell to me
There was a problem hiding this comment.
It just feels like it got hacked onto the language. Its very handy, but something feels strange about it. I'm just murmuring out loud, ignore me 👍
There was a problem hiding this comment.
true, functionality-wise I think it's quite nice though 😛
daemon/handler.go
Outdated
| // Run daemon on port | ||
| log.Println("Serving daemon on port " + port) | ||
| mux := http.NewServeMux() | ||
| // Example usage of `authorized' decorator. |
There was a problem hiding this comment.
Can kill my old silly comments, think it’s clear what’s goin down here now😜
* New logger class and functions * Migrated "--stream"-supported handlers to new logger * Removed daemon dependency on pkg "log" due to datetime duplication when reporting container logs
bobheadxi
added
pr: wip
bobheadxi
added
pr: finalized
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⌛ Status: Ready
🎟️ Ticket(s): Closes #37
👷 Changes
inertia local logs --stream, or access most recent logs withinertia local logsinertia local logs docker-composeorinertia local logs mycontainerspecifically-Reworked logging,
though this is bugged right now:https://github.com/ubclaunchpad/inertia/blob/rob/%2337-deployment-logs/daemon/handler.go#L196 doesn't seem to properly return the error to the client - I think its still floating around somewhere because if I runinertia local upagain, the line that was supposed to be returned shows up in the container logs alongside the first log from the second callFIXED as of 754d625, turns out a
newlineis needed for the flush to trigger🔦 Testing Instructions