Skip to content
This repository has been archived by the owner on May 29, 2020. It is now read-only.

gateway: replace context.Background() with r.Context() in gRPC requests #101

Closed
bwdmonkey opened this issue Nov 24, 2018 · 0 comments
Closed

gateway: replace context.Background() with r.Context() in gRPC requests #101

bwdmonkey opened this issue Nov 24, 2018 · 0 comments
Assignees
@bobheadxi
Labels
/gateway
Projects
Backend MVP

Comments

@bwdmonkey
Copy link
Member

bwdmonkey commented Nov 24, 2018 •
edited

https://golang.org/pkg/net/http/#Request.Context
@bwdmonkey bwdmonkey mentioned this issue Nov 24, 2018
Merged
2 tasks
@bobheadxi bobheadxi changed the title Replace context.Background() with r.Context() gateway: replace context.Background() with r.Context() in gRPC requests Nov 24, 2018
@bobheadxi bobheadxi added this to To do in Backend MVP via automation Nov 24, 2018
@bobheadxi bobheadxi mentioned this issue Nov 25, 2018
Closed
@bobheadxi bobheadxi self-assigned this Nov 25, 2018
@bobheadxi bobheadxi moved this from To do to In progress in Backend MVP Nov 25, 2018
@bobheadxi bobheadxi mentioned this issue Nov 25, 2018
Merged
bobheadxi added a commit that referenced this issue Nov 25, 2018
@bobheadxi
Merge branch 'master' into gateway/#101-req-context
5f7465e
Backend MVP automation moved this from In progress to Done Nov 25, 2018
bobheadxi added a commit that referenced this issue Nov 25, 2018
@bobheadxi
Merge pull request #104 from ubclaunchpad/gateway/#101-req-context
753fde7 
gateway: use request.Context for router calls to core
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bobheadxi bobheadxi

Labels
/gateway
Projects
No open projects
Backend MVP
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bwdmonkey @bobheadxi