This repository has been archived by the owner on Oct 21, 2019. It is now read-only.
Move is_tech_lead to team_members and misc improvements #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobheadxi
reviewed
Jun 23, 2018
There was a problem hiding this comment.
I feel like the loss of the tech-lead level permissioning is a bit disappointing - can that still be implemented with this setup?
As an administrative tool, especially re: #84, I think it's pretty important that there is one level of permissions beneath admin.
| # e.g: $ make migration MIGRATION=6_add_is_tech_lead | ||
| .PHONY: migrate | ||
| migrate: | ||
| @docker-compose exec postgres bash -c \ |
| @@ -13,7 +13,7 @@ import ( | |||
| func NewAddUserCmd(ch cmd.CommandHandler) *cmd.Command { | |||
| return &cmd.Command{ | |||
| Name: "add-user", | |||
| HelpText: "Add a user to a team (admins and tech leads only)", | |||
| HelpText: "Add a user to a team (admins only)", | |||
There was a problem hiding this comment.
are we removing all tech-lead level permissions?
There was a problem hiding this comment.
I just took it out for now because I didn't want to write the extra code to check if a given member is a tech lead, since that would require an extra DB query each time we check the user's privilege level. But I was just lazy so I'll add it back in.
| } | ||
| return names, noParams | ||
| if len(msg) == 0 { | ||
| msg = "There are currently no admins :feelsbadman:" |
| @@ -17,17 +16,20 @@ func NewTechLeadsCmd(ch cmd.CommandHandler) *cmd.Command { | |||
| } | |||
| } | |||
|
|
|||
| // listAdmins displays Launch Pad admins | |||
| // listTechLeads displays Launch Pad tech leads | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
is_tech_leadfrommemberstoteam_membersrelation table. Now a member can be a lead of multiple teams and teams can have multiple leads.toggle-tech-leadsandtech-leadsaccordingly.