Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rmcreyes/#28 slackevent model #40

Closed
wants to merge 2 commits into from

Conversation

rmcreyes
Copy link
Collaborator

Pull Request

Description

Give a brief description of your changes:
Implemented the SlackEvent class, and created tests for it in tests/model/slackevent_test.py.

Testing

If testing this change requires extra setup, please document it here:

Ticket(s)

Closes #28

(Create a copy of that line for each Github Issue affected,
and replace "Affects" with "Closes" if merging this will close the relevant ticket.)

@rmcreyes rmcreyes requested a review from a team as a code owner October 11, 2018 07:20
@codecov
Copy link

codecov bot commented Oct 11, 2018

Codecov Report

Merging #40 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #40   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           3      4    +1     
  Lines         105    145   +40     
=====================================
+ Hits          105    145   +40
Impacted Files Coverage Δ
tests/model/slackevent_test.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42ad5c9...e2cb7d8. Read the comment docs.

@rmcreyes rmcreyes closed this Oct 11, 2018
@michaelfu1029 michaelfu1029 deleted the rmcreyes/#28-slackevent-model branch March 16, 2019 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add SlackEvent to data model
1 participant