Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Team Command Parsing #60

Merged
merged 18 commits into from
Nov 10, 2018
Merged

Implement Team Command Parsing #60

merged 18 commits into from
Nov 10, 2018

Conversation

vyzw
Copy link
Contributor

@vyzw vyzw commented Oct 27, 2018

Pull Request

Description

Added team command parsing and TeamCommands.md reference. Added tests for parsing.

TODO:

  • Implement and test edit command
  • Implement Bruno's suggestion (use @slack Name in commands -> give slack id to handler) (and create platform option?) (in a different PR)
  • Write help_text (let's do that in a separate PR)

Testing

If testing this change requires extra setup, please document it here:

Ticket(s)

Affects #50, affects #51, affects #52

(Create a copy of that line for each Github Issue affected,
and replace "Affects" with "Closes" if merging this will close the relevant ticket.)

@vyzw vyzw requested a review from a team October 27, 2018 20:02
@codecov
Copy link

codecov bot commented Oct 27, 2018

Codecov Report

Merging #60 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #60   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           9     10    +1     
  Lines         302    340   +38     
=====================================
+ Hits          302    340   +38
Impacted Files Coverage Δ
tests/command/commands/team_test.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a92a497...651ad9b. Read the comment docs.

rwblickhan
rwblickhan previously approved these changes Oct 27, 2018
docs/TeamCommands.md Outdated Show resolved Hide resolved
@chuck-sys chuck-sys requested review from a team and removed request for a team October 27, 2018 22:01
@bobheadxi
Copy link
Member

Make sure you set your username and email in git on your computer, otherwise the commits don't have a GitHub account attached to them:

image

Copy link
Collaborator

@chuck-sys chuck-sys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I remember, there was also another PR that was merged regarding commands/user.py. Some of the same issues (static class variables and long initializations that aren't in functions) are present. May want to submit another PR to fix that (and issue, to get our counts up).

command/commands/team.py Outdated Show resolved Hide resolved
command/commands/team.py Outdated Show resolved Hide resolved
command/commands/team.py Outdated Show resolved Hide resolved
tests/command/commands/team_test.py Show resolved Hide resolved
@vyzw vyzw changed the title [WIP] Implement Team Command Parsing Implement Team Command Parsing Nov 10, 2018
@vyzw vyzw merged commit fb0e485 into master Nov 10, 2018
@vyzw vyzw deleted the teamcommand branch November 10, 2018 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants