Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On build failure, Harbormaster is not notified. #26

Closed
lavahot opened this issue Jun 7, 2015 · 9 comments
Closed

On build failure, Harbormaster is not notified. #26

lavahot opened this issue Jun 7, 2015 · 9 comments

Comments

@lavahot
Copy link

lavahot commented Jun 7, 2015

Having now restarted Harbormaster builds on my setup many times, I have noticed a trend that when the build fails (now every time, see #19), it does not send back a failure message to harbormaster. Instead Harbormaster patiently waits for the callback on that build and gives a status of "Building".
@ascandella
Copy link
Contributor

Can you post the build logs? Are you properly passing the PHID string parameter?

@lavahot
Copy link
Author

lavahot commented Jun 7, 2015

Here's the harbormaster build logs:

Build Log 14 (http://nvdbuild.cloudapp.net/buildByToken/buildWithParameters?job=Test&token=BLURGHNOTATOKEN&DIFF_ID=1&PHID=PHID-HMBT-275ljsnmajwwtzl5k6br - http-body)
1 Scheduled.
2

@ascandella
Copy link
Contributor

Looks like I don't have permission to view the text. Could you paste me the output of the build log?

@ascandella
Copy link
Contributor

Also, does the job have String parameters for PHID and DIFF_ID (or perhaps they're being ignored?). Only way to tell is to see the build output

@lavahot
Copy link
Author

lavahot commented Jun 7, 2015

Well, the build is broken for reasons I recently put into #19, but I'll paste a larger version here:

Usage Exception: This command requires arc to connect to a Phabricator install, but no
Phabricator installation is configured. To configure a Phabricator URI:

  • set a default location with arc set-config default <uri>; or
  • specify --conduit-uri=uri explicitly; or
  • run arc in a working copy with an '.arcconfig'.

[phabricator] Unable to parse JSON from response:
FATAL: Invalid JSON String
net.sf.json.JSONException: Invalid JSON String
at net.sf.json.JSONSerializer.toJSON(JSONSerializer.java:143)
at net.sf.json.JSONSerializer.toJSON(JSONSerializer.java:103)
at net.sf.json.groovy.JsonSlurper.parseText(JsonSlurper.java:80)
at com.uber.jenkins.phabricator.conduit.ArcanistClient.callConduit(ArcanistClient.java:70)
at com.uber.jenkins.phabricator.conduit.Differential.callConduit(Differential.java:85)
at com.uber.jenkins.phabricator.conduit.Differential.(Differential.java:49)
at com.uber.jenkins.phabricator.PhabricatorBuildWrapper.setUp(PhabricatorBuildWrapper.java:87)
at hudson.model.Build$BuildExecution.doRun(Build.java:156)
at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:537)
at hudson.model.Run.execute(Run.java:1744)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:98)
at hudson.model.Executor.run(Executor.java:374)
Usage Exception: This command requires arc to connect to a Phabricator install, but no
Phabricator installation is configured. To configure a Phabricator URI:

  • set a default location with arc set-config default <uri>; or
  • specify --conduit-uri=uri explicitly; or
  • run arc in a working copy with an '.arcconfig'.

[phabricator] Unable to parse JSON from response:
ERROR: Build step failed with exception
net.sf.json.JSONException: Invalid JSON String
at net.sf.json.JSONSerializer.toJSON(JSONSerializer.java:143)
at net.sf.json.JSONSerializer.toJSON(JSONSerializer.java:103)
at net.sf.json.groovy.JsonSlurper.parseText(JsonSlurper.java:80)
at com.uber.jenkins.phabricator.conduit.ArcanistClient.callConduit(ArcanistClient.java:70)
at com.uber.jenkins.phabricator.conduit.Differential.callConduit(Differential.java:85)
at com.uber.jenkins.phabricator.conduit.Differential.(Differential.java:49)
at com.uber.jenkins.phabricator.PhabricatorNotifier.perform(PhabricatorNotifier.java:117)
at hudson.tasks.BuildStepMonitor$1.perform(BuildStepMonitor.java:20)
at hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:779)
at hudson.model.AbstractBuild$AbstractBuildExecution.performAllBuildSteps(AbstractBuild.java:726)
at hudson.model.Build$BuildExecution.post2(Build.java:185)
at hudson.model.AbstractBuild$AbstractBuildExecution.post(AbstractBuild.java:671)
at hudson.model.Run.execute(Run.java:1769)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:98)
at hudson.model.Executor.run(Executor.java:374)
Build step 'Post to Phabricator' marked build as failure
Finished: FAILURE

@szhou1234
Copy link

I have the same failure for my patch https://code.uberinternal.com/D114594 https://code.uberinternal.com/D114594.

Thanks,
Simon from Supply Growth team

On Jun 6, 2015, at 7:34 PM, Taylor Mansfield notifications@github.com wrote:

Well, the build is broken for reasons I recently put into #19 #19, but I'll paste a larger version here:

Usage Exception: This command requires arc to connect to a Phabricator install, but no
Phabricator installation is configured. To configure a Phabricator URI:

set a default location with arc set-config default ; or
specify --conduit-uri=uri explicitly; or
run arc in a working copy with an '.arcconfig'.
[phabricator] Unable to parse JSON from response:
FATAL: Invalid JSON String
net.sf.json.JSONException: Invalid JSON String
at net.sf.json.JSONSerializer.toJSON(JSONSerializer.java:143)
at net.sf.json.JSONSerializer.toJSON(JSONSerializer.java:103)
at net.sf.json.groovy.JsonSlurper.parseText(JsonSlurper.java:80)
at com.uber.jenkins.phabricator.conduit.ArcanistClient.callConduit(ArcanistClient.java:70)
at com.uber.jenkins.phabricator.conduit.Differential.callConduit(Differential.java:85)
at com.uber.jenkins.phabricator.conduit.Differential.(Differential.java:49)
at com.uber.jenkins.phabricator.PhabricatorBuildWrapper.setUp(PhabricatorBuildWrapper.java:87)
at hudson.model.Build$BuildExecution.doRun(Build.java:156)
at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:537)
at hudson.model.Run.execute(Run.java:1744)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:98)
at hudson.model.Executor.run(Executor.java:374)
Usage Exception: This command requires arc to connect to a Phabricator install, but no
Phabricator installation is configured. To configure a Phabricator URI:

set a default location with arc set-config default ; or
specify --conduit-uri=uri explicitly; or
run arc in a working copy with an '.arcconfig'.
[phabricator] Unable to parse JSON from response:
ERROR: Build step failed with exception
net.sf.json.JSONException: Invalid JSON String
at net.sf.json.JSONSerializer.toJSON(JSONSerializer.java:143)
at net.sf.json.JSONSerializer.toJSON(JSONSerializer.java:103)
at net.sf.json.groovy.JsonSlurper.parseText(JsonSlurper.java:80)
at com.uber.jenkins.phabricator.conduit.ArcanistClient.callConduit(ArcanistClient.java:70)
at com.uber.jenkins.phabricator.conduit.Differential.callConduit(Differential.java:85)
at com.uber.jenkins.phabricator.conduit.Differential.(Differential.java:49)
at com.uber.jenkins.phabricator.PhabricatorNotifier.perform(PhabricatorNotifier.java:117)
at hudson.tasks.BuildStepMonitor$1.perform(BuildStepMonitor.java:20)
at hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:779)
at hudson.model.AbstractBuild$AbstractBuildExecution.performAllBuildSteps(AbstractBuild.java:726)
at hudson.model.Build$BuildExecution.post2(Build.java:185)
at hudson.model.AbstractBuild$AbstractBuildExecution.post(AbstractBuild.java:671)
at hudson.model.Run.execute(Run.java:1769)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:98)
at hudson.model.Executor.run(Executor.java:374)
Build step 'Post to Phabricator' marked build as failure
Finished: FAILURE

—
Reply to this email directly or view it on GitHub #26 (comment).

@ascandella
Copy link
Contributor

Simon, will you please file a ticket on internal phab and assign it to me
with devexp as the team?

On Saturday, June 6, 2015, szhou1234 notifications@github.com wrote:

I have the same failure for my patch https://code.uberinternal.com/D114594
https://code.uberinternal.com/D114594.

Thanks,
Simon from Supply Growth team

On Jun 6, 2015, at 7:34 PM, Taylor Mansfield <notifications@github.com
javascript:_e(%7B%7D,'cvml','notifications@github.com');> wrote:

Well, the build is broken for reasons I recently put into #19 <
https://github.com/uber/phabricator-jenkins-plugin/issues/19>, but I'll
paste a larger version here:

Usage Exception: This command requires arc to connect to a Phabricator
install, but no
Phabricator installation is configured. To configure a Phabricator URI:

set a default location with arc set-config default ; or
specify --conduit-uri=uri explicitly; or
run arc in a working copy with an '.arcconfig'.
[phabricator] Unable to parse JSON from response:
FATAL: Invalid JSON String
net.sf.json.JSONException: Invalid JSON String
at net.sf.json.JSONSerializer.toJSON(JSONSerializer.java:143)
at net.sf.json.JSONSerializer.toJSON(JSONSerializer.java:103)
at net.sf.json.groovy.JsonSlurper.parseText(JsonSlurper.java:80)
at
com.uber.jenkins.phabricator.conduit.ArcanistClient.callConduit(ArcanistClient.java:70)
at
com.uber.jenkins.phabricator.conduit.Differential.callConduit(Differential.java:85)
at
com.uber.jenkins.phabricator.conduit.Differential.(Differential.java:49)
at
com.uber.jenkins.phabricator.PhabricatorBuildWrapper.setUp(PhabricatorBuildWrapper.java:87)
at hudson.model.Build$BuildExecution.doRun(Build.java:156)
at
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:537)
at hudson.model.Run.execute(Run.java:1744)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:98)
at hudson.model.Executor.run(Executor.java:374)
Usage Exception: This command requires arc to connect to a Phabricator
install, but no
Phabricator installation is configured. To configure a Phabricator URI:

set a default location with arc set-config default ; or
specify --conduit-uri=uri explicitly; or
run arc in a working copy with an '.arcconfig'.
[phabricator] Unable to parse JSON from response:
ERROR: Build step failed with exception
net.sf.json.JSONException: Invalid JSON String
at net.sf.json.JSONSerializer.toJSON(JSONSerializer.java:143)
at net.sf.json.JSONSerializer.toJSON(JSONSerializer.java:103)
at net.sf.json.groovy.JsonSlurper.parseText(JsonSlurper.java:80)
at
com.uber.jenkins.phabricator.conduit.ArcanistClient.callConduit(ArcanistClient.java:70)
at
com.uber.jenkins.phabricator.conduit.Differential.callConduit(Differential.java:85)
at
com.uber.jenkins.phabricator.conduit.Differential.(Differential.java:49)
at
com.uber.jenkins.phabricator.PhabricatorNotifier.perform(PhabricatorNotifier.java:117)
at hudson.tasks.BuildStepMonitor$1.perform(BuildStepMonitor.java:20)
at
hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:779)
at
hudson.model.AbstractBuild$AbstractBuildExecution.performAllBuildSteps(AbstractBuild.java:726)
at hudson.model.Build$BuildExecution.post2(Build.java:185)
at
hudson.model.AbstractBuild$AbstractBuildExecution.post(AbstractBuild.java:671)
at hudson.model.Run.execute(Run.java:1769)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:98)
at hudson.model.Executor.run(Executor.java:374)
Build step 'Post to Phabricator' marked build as failure
Finished: FAILURE

—
Reply to this email directly or view it on GitHub <
#26 (comment)
.

—
Reply to this email directly or view it on GitHub
#26 (comment)
.

@szhou1234
Copy link

Aiden,

Here it is: https://code.uberinternal.com/T101709 https://code.uberinternal.com/T101709

Thanks,
Simon from Supply Growth team

On Jun 6, 2015, at 8:47 PM, Aiden Scandella notifications@github.com wrote:

Simon, will you please file a ticket on internal phab and assign it to me
with devexp as the team?

On Saturday, June 6, 2015, szhou1234 notifications@github.com wrote:

I have the same failure for my patch https://code.uberinternal.com/D114594
https://code.uberinternal.com/D114594.

Thanks,
Simon from Supply Growth team

On Jun 6, 2015, at 7:34 PM, Taylor Mansfield <notifications@github.com
javascript:_e(%7B%7D,'cvml','notifications@github.com');> wrote:

Well, the build is broken for reasons I recently put into #19 <
https://github.com/uber/phabricator-jenkins-plugin/issues/19>, but I'll
paste a larger version here:

Usage Exception: This command requires arc to connect to a Phabricator
install, but no
Phabricator installation is configured. To configure a Phabricator URI:

set a default location with arc set-config default ; or
specify --conduit-uri=uri explicitly; or
run arc in a working copy with an '.arcconfig'.
[phabricator] Unable to parse JSON from response:
FATAL: Invalid JSON String
net.sf.json.JSONException: Invalid JSON String
at net.sf.json.JSONSerializer.toJSON(JSONSerializer.java:143)
at net.sf.json.JSONSerializer.toJSON(JSONSerializer.java:103)
at net.sf.json.groovy.JsonSlurper.parseText(JsonSlurper.java:80)
at
com.uber.jenkins.phabricator.conduit.ArcanistClient.callConduit(ArcanistClient.java:70)
at
com.uber.jenkins.phabricator.conduit.Differential.callConduit(Differential.java:85)
at
com.uber.jenkins.phabricator.conduit.Differential.(Differential.java:49)
at
com.uber.jenkins.phabricator.PhabricatorBuildWrapper.setUp(PhabricatorBuildWrapper.java:87)
at hudson.model.Build$BuildExecution.doRun(Build.java:156)
at
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:537)
at hudson.model.Run.execute(Run.java:1744)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:98)
at hudson.model.Executor.run(Executor.java:374)
Usage Exception: This command requires arc to connect to a Phabricator
install, but no
Phabricator installation is configured. To configure a Phabricator URI:

set a default location with arc set-config default ; or
specify --conduit-uri=uri explicitly; or
run arc in a working copy with an '.arcconfig'.
[phabricator] Unable to parse JSON from response:
ERROR: Build step failed with exception
net.sf.json.JSONException: Invalid JSON String
at net.sf.json.JSONSerializer.toJSON(JSONSerializer.java:143)
at net.sf.json.JSONSerializer.toJSON(JSONSerializer.java:103)
at net.sf.json.groovy.JsonSlurper.parseText(JsonSlurper.java:80)
at
com.uber.jenkins.phabricator.conduit.ArcanistClient.callConduit(ArcanistClient.java:70)
at
com.uber.jenkins.phabricator.conduit.Differential.callConduit(Differential.java:85)
at
com.uber.jenkins.phabricator.conduit.Differential.(Differential.java:49)
at
com.uber.jenkins.phabricator.PhabricatorNotifier.perform(PhabricatorNotifier.java:117)
at hudson.tasks.BuildStepMonitor$1.perform(BuildStepMonitor.java:20)
at
hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:779)
at
hudson.model.AbstractBuild$AbstractBuildExecution.performAllBuildSteps(AbstractBuild.java:726)
at hudson.model.Build$BuildExecution.post2(Build.java:185)
at
hudson.model.AbstractBuild$AbstractBuildExecution.post(AbstractBuild.java:671)
at hudson.model.Run.execute(Run.java:1769)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:98)
at hudson.model.Executor.run(Executor.java:374)
Build step 'Post to Phabricator' marked build as failure
Finished: FAILURE

—
Reply to this email directly or view it on GitHub <
#26 (comment)
.

—
Reply to this email directly or view it on GitHub
#26 (comment)
.

—
Reply to this email directly or view it on GitHub #26 (comment).

@lavahot
Copy link
Author

lavahot commented Jun 7, 2015

So after properly configuring my instance to get source from the git repo with a correct uri, this works on both success and failure of the job. I think in the future there should be some URI settings for Jenkins so it doesn't have to rely on proper .arcconfig to update Phabricator, but instead prefer information from one if available.

Since my part in this is done, and Simon has his own ticket elsewhere, I'm going to close this. Thanks again!

@lavahot lavahot closed this as completed Jun 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ascandella @lavahot @szhou1234