tell harbormaster how to link back to jenkins results #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary for more complex nested arguments instead of just flat kv maps.
| @@ -158,10 +159,14 @@ public final boolean perform(final AbstractBuild<?, ?> build, final Launcher lau | |||
|
|
|||
| String commentAction = "none"; | |||
| if (runHarbormaster) { | |||
| logger.info("harbormaster", "Sending build result to Harbormaster with PHID '" + phid + "', success: " + harbormasterSuccess); | |||
| logger.info("harbormaster", "Sending Harbormaster BUILD_URL via PHID: " + phid); | |||
| Task.Result sendUriResult = new SendHarbormasterUriTask(logger, diffClient, phid, environment.get("BUILD_URL")).run(); | |||
There was a problem hiding this comment.
We're grabbing the BUILD_URL environment variable above on line 144 -- let's move it out into a final String variable to dedup the logic for fetching it
|
Looks good, pending some tests |
It would be useful if Differential could provide a link back to Jenkins since engineers will probably want to look at the results of failing builds. This can be accomplished by uploading a uri "artifact" for display. Ideally we would tell Harbormaster the uri as soon as the build is started, but I didn't want to complicated this plugin by adding even more extension points. See https://secure.phabricator.com/T8659 for details.
cburroughs
force-pushed
the
uri-artifact
branch
from
fb8936f
to
50a3c9a
Compare
|
Updated with a single env call for |
|
Looks good! Thanks for the PR. Will merge when tests come back. |
|
Oracle JDK 8 continues to be broken in Travis. Merging. |
ascandella
added a commit
that referenced
this pull request
Aug 17, 2015
tell harbormaster how to link back to jenkins results
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also https://secure.phabricator.com/T8659