-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add full locking to workflow.Context to work around shutdown races #1139
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regrettable but pretty simple to add. When goroutines are shut down correctly, these locks can (and should) be removed.
Pull Request Test Coverage Report for Build 957cbed2-c422-42c6-bf41-543d48cd82e2
💛 - Coveralls |
:\ no, I think this may change execution order, given the order of propagation. gonna try something else. |
Were you able to repro the issue in your test? |
@demirkayaender not the one I was aiming for, unfortunately. I found yet another instead :|
I haven't yet reproduced their |
demirkayaender
added a commit
to demirkayaender/cadence-client
that referenced
this pull request
Oct 11, 2021
Test taken from uber-go#1139
demirkayaender
added a commit
to demirkayaender/cadence-client
that referenced
this pull request
Oct 15, 2021
Test taken from uber-go#1139
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regrettable but pretty simple to add.
When goroutines are shut down correctly, these locks can (and should) be removed.
.... and then I discovered that Close has synchronous side effects.
I'm not super confident that this is stable, I'm not familiar enough with all the code to know for sure :|
Unfortunately it looks like #1124 is not sufficient in practice, there are other races in our users' workflows :
This is a (nearly) direct mimicry of go's context.go locking in 1.13 (our oldest supported version), but beyond that I have not really thought about the details. It fixes the new test's new race though, at least.