Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add canonical import path #192

Merged
merged 1 commit into from
Jun 7, 2018
Merged

Add canonical import path #192

merged 1 commit into from
Jun 7, 2018

Conversation

abhinav
Copy link
Collaborator

@abhinav abhinav commented Jun 7, 2018

This adds the canonical import path directive so that people don't
try to import this as github.com/uber-go/dig and see cryptic error
messages.

This adds the canonical import path directive so that people don't
try to import this as github.com/uber-go/dig and see cryptic error
messages.
@abhinav abhinav requested a review from akshayjshah June 7, 2018 21:42
@codecov
Copy link

codecov bot commented Jun 7, 2018

Codecov Report

Merging #192 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #192   +/-   ##
======================================
  Coverage    98.8%   98.8%           
======================================
  Files           8       8           
  Lines         754     754           
======================================
  Hits          745     745           
  Misses          9       9

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15c6734...b256eeb. Read the comment docs.

@abhinav abhinav requested a review from amckinney June 7, 2018 21:45
@abhinav abhinav merged commit 45540ff into master Jun 7, 2018
@abhinav abhinav deleted the abg/canonical-import branch June 7, 2018 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants