Switch to gofrs/uuid #361
Merged
Switch to gofrs/uuid #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The satori/go.uuid package has some serious known problems, particularly with the generation of V4 UUIDs. It's also no longer maintained. The recommended replacement is gofrs/uuid. Additionally, the gofrs team accepted the change I made to the uuid package about two years ago and released 3.1.0 which includes a feature needed by the DOSA memory connector. This also removes that workaround.
rkuris
force-pushed
the
rkuris/gofrs-uuid
branch
from
9852bdf
to
568fb0e
Compare
|
Fixes #343 |
|
seems reasonable to me. @phliar are you ok with this? |
awaniim
approved these changes
Sep 11, 2018
twilly
pushed a commit
to twilly/dosa
that referenced
this pull request
Oct 16, 2018
961abe5 swapped out `satori/go.uuid` with `gofrs/uuid` but missed this one spot in a routing connector test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The satori/go.uuid package has some serious known problems, particularly
with the generation of V4 UUIDs. It's also no longer maintained. The
recommended replacement is gofrs/uuid.
Additionally, the gofrs team accepted the change I made to the uuid
package about two years ago and released 3.1.0 which includes a feature
needed by the DOSA memory connector. This also removes that workaround.