Override provider in value for group provider

uber-go · Mar 13, 2017 · 18a7168 · 18a7168
1 parent 5653f52
commit 18a7168
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/config/provider_group.go b/config/provider_group.go
@@ -58,6 +58,7 @@ func (p providerGroup) Get(key string) Value {
 	// here we add a new root, which defines the "scope" at which
 	// PopulateStructs will look for values.
 	cv.root = p
+	cv.provider = p
 	return cv
 }
 

diff --git a/config/provider_group_test.go b/config/provider_group_test.go
@@ -119,6 +119,19 @@ func TestScope_WithGetFromValue(t *testing.T) {
 	require.False(t, fx.Get("fx").HasValue())
 }
 
+func TestProviderGroupScopingValue(t *testing.T) {
+	t.Parallel()
+	fst := []byte(`
+logging:`)
+
+	snd := []byte(`
+logging:
+  enabled: true
+`)
+	pg := NewProviderGroup("group", NewYAMLProviderFromBytes(snd), NewYAMLProviderFromBytes(fst))
+	assert.True(t, pg.Get("logging").Get("enabled").AsBool())
+}
+
 type mockDynamicProvider struct {
 	data      map[string]interface{}
 	callBacks map[string]ChangeCallback