Fix close order and build failure

uber-go · Apr 24, 2017 · 3da9558 · 3da9558
1 parent a57e7cd
commit 3da9558
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/service2/service2.go b/service2/service2.go
@@ -26,6 +26,7 @@ import (
 
 	"go.uber.org/dig"
 	"go.uber.org/fx/config"
+	"go.uber.org/zap"
 )
 
 // Service foo
@@ -52,8 +53,10 @@ func (s *Service) Start() {
 func (s *Service) Stop() {
 	// close all dig stuff
 	log.Println("Stopping...")
-	for _, closer := range _closers {
-		closer.Close()
+	for i := len(_closers) - 1; i >= 0; i-- {
+		if err := _closers[i].Close(); err != nil {
+			zap.L().Error("Failure to close", zap.Error(err))
+		}
 	}
 }