Embed http.Client as a pointer

modules/uhttp/client/client.go

@@ -33,12 +33,12 @@ import (
 
 // Client wraps around a http client
 type Client struct {
-	http.Client
+	*http.Client
 	filters []Filter
 }
 
 // New creates a new instance of uhttp Client
-func New(client http.Client, filters ...Filter) *Client {
+func New(client *http.Client, filters ...Filter) *Client {
 	filters = append(filters, FilterFunc(tracingFilter))
 	return &Client{Client: client, filters: filters}
 }
@@ -56,7 +56,7 @@ func (c *Client) Do(ctx core.Context, req *http.Request) (resp *http.Response, e
 }
 
 func (c *Client) do(ctx core.Context, req *http.Request) (resp *http.Response, err error) {
-	return ctxhttp.Do(ctx, &c.Client, req)
+	return ctxhttp.Do(ctx, c.Client, req)
 }
 
 // Get is a context-aware, filter-enabled extension of Get() in http.Client

modules/uhttp/client/client_test.go

@@ -34,11 +34,11 @@ import (
 )
 
 var _defaultHTTPClient = &http.Client{Timeout: 2 * time.Second}
-var _defaultUHTTPClient = New(*_defaultHTTPClient)
+var _defaultUHTTPClient = New(_defaultHTTPClient)
 
 func TestNew(t *testing.T) {
-	uhttpClient := New(*_defaultHTTPClient)
-	assert.Equal(t, *_defaultHTTPClient, uhttpClient.Client)
+	uhttpClient := New(_defaultHTTPClient)
+	assert.Equal(t, _defaultHTTPClient, uhttpClient.Client)
 	assert.Equal(t, 1, len(uhttpClient.filters))
 }
 
@@ -50,7 +50,7 @@ func TestClientDo(t *testing.T) {
 }
 
 func TestClientDoWithoutFilters(t *testing.T) {
-	uhttpClient := &Client{Client: *_defaultHTTPClient}
+	uhttpClient := &Client{Client: _defaultHTTPClient}
 	svr := startServer()
 	req := createHTTPClientRequest(svr.URL)
 	resp, err := uhttpClient.Do(createContext(), req)