address glibsm comment

uber-go · Feb 14, 2017 · d71bcf9 · d71bcf9
1 parent e7cb200
commit d71bcf9
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/modules/rpc/handler.go b/modules/rpc/handler.go
@@ -30,7 +30,7 @@ import (
 	"go.uber.org/yarpc/api/transport"
 )
 
-const panicResponse = "Server Error"
+const _panicResponse = "Server Error"
 
 type contextInboundMiddleware struct {
 	service.Host
@@ -111,6 +111,6 @@ func panicRecovery(ctx context.Context) {
 		fx.Logger(ctx).Error("Panic recovered serving request", "error", err)
 		// rethrow panic back to yarpc
 		// before https://github.com/yarpc/yarpc-go/issues/734 fixed, throw a generic error.
-		panic(panicResponse)
+		panic(_panicResponse)
 	}
 }
diff --git a/modules/rpc/handler_test.go b/modules/rpc/handler_test.go
@@ -131,7 +131,7 @@ func TestOnewayInboundMiddleware_panic(t *testing.T) {
 
 func testPanicHandler(t *testing.T) {
 	r := recover()
-	assert.EqualValues(t, r, panicResponse)
+	assert.EqualValues(t, r, _panicResponse)
 }
 
 type panicUnaryHandler struct{}