Allow stopping app after Stop() has been called #1019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting from 1.19, calling Stop() when an app has been stopped returns an error. This actually is an unexpected change for many users who have been using fxtest for testing their apps. Specifically, if they have a server that errors out when tests are written, these will often trigger Stop() to be called many times..
moisesvega
approved these changes
Jan 9, 2023
Codecov Report
@@ Coverage Diff @@
## master #1019 +/- ##
==========================================
- Coverage 98.14% 98.04% -0.11%
==========================================
Files 39 39
Lines 1992 1992
==========================================
- Hits 1955 1953 -2
- Misses 29 31 +2
Partials 8 8
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
tchung1118
approved these changes
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting from 1.19, calling Stop() when an app has been stopped returns an error.
This actually is an unexpected change for many users who have been using fxtest for testing their apps. Specifically, if they have a server that errors out when tests are written, these will often trigger Stop() to be called many times..