Return a key with the error on Value.Populate failures #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
alsam-configErrorPath
branch
from
cf514df
to
40fde52
Compare
madhuravi
reviewed
Mar 21, 2017
config/decoder.go
Outdated
| @@ -206,6 +207,10 @@ func addSeparator(key string) string { | |||
| return key | |||
| } | |||
|
|
|||
| func addKeyToError(key string, err error) error { | |||
There was a problem hiding this comment.
nit: errorWithKey(err error, key string) is more meaningful.
madhuravi
reviewed
Mar 21, 2017
config/decoder.go
Outdated
| @@ -342,7 +347,8 @@ func (d *decoder) mapping(childKey string, value reflect.Value, def string) erro | |||
| for key := range v { | |||
| subKey := fmt.Sprintf("%v", key) | |||
| if subKey == "" { | |||
| return fmt.Errorf("empty key leads to ambiguity for path: %q", childKey) | |||
| // We can confuse an empty map key with a root element. | |||
| return addKeyToError(childKey, errors.New("empty map key is ambigious")) | |||
There was a problem hiding this comment.
nit: is it worth adding another function, newErrorWithKey(msg string, key string), so we don't have to create error twice? A small performance win but not sure how much of a difference it makes. Will leave this to you.
There was a problem hiding this comment.
I would rather to keep an error here, so stacktrace is not going to get too long.
madhuravi
approved these changes
Mar 21, 2017
glibsm
pushed a commit
that referenced
this pull request
Mar 28, 2017
We provide only information about types, omitting the offending key, which can be confusing for users. The easiest way would be to return error from decoder.unmarshal, but because it is recursive, we need to track leafs and attach the offending key on leafs.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We provide only information about types, omitting the offending key, which can be confusing for users. The easiest way would be to return error from
decoder.unmarshal, but because it is recursive, we need to track leafs and attach the offending key on leafs.