Update Travis build for glue-dig-b3 branch #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
April 5, 2018 16:50
We no longer need to be quite so picky about the documentation on this branch, and this lint check is blocking actual bug fixes.
glibsm
reviewed
Apr 9, 2018
.build/lint.mk
Outdated
| @echo "Ensuring generated doc.go are up to date" | ||
| $(ECHO_V)$(MAKE) gendoc | ||
| $(ECHO_V)[ -z "$(shell git status --porcelain | grep '\bdoc.go$$')" ] || echo "Commit updated doc.go changes" | tee -a $(LINT_LOG) | ||
| $(ECHO_V)[ ! -s $(LINT_LOG) ] |
There was a problem hiding this comment.
removing this last line effectively ignores make lint
not sure if that's the intention or just to remove the godoc check
There was a problem hiding this comment.
Blargh, you're right. Thanks for the catch :/
abhinav
approved these changes
Apr 9, 2018
glibsm
approved these changes
Apr 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're still backporting fixes to this ancient branch, but the the build is unnecessarily finicky. Now that this isn't the mainline development branch, we can remove some checks.
This also updates to the latest Go releases that we support.