Refactor Done() to use a broadcasted Signal type for future features. #984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #984 +/- ##
=======================================
Coverage 98.68% 98.69%
=======================================
Files 38 39 +1
Lines 1596 1608 +12
=======================================
+ Hits 1575 1587 +12
Misses 15 15
Partials 6 6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
abhinav
reviewed
Nov 1, 2022
abhinav
reviewed
Nov 1, 2022
Co-authored-by: Abhinav Gupta <mail@abhinavg.net>
Co-authored-by: Abhinav Gupta <mail@abhinavg.net>
Co-authored-by: Abhinav Gupta <mail@abhinavg.net>
Co-authored-by: Abhinav Gupta <mail@abhinavg.net>
abhinav
approved these changes
Nov 1, 2022
sywhang
approved these changes
Nov 1, 2022
Co-authored-by: Sung Yoon Whang <sungyoonwhang@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates a new public struct type
ShutdownSignaland moves broadcast of operating system signals to a standalone type in it's own source file. This allows for the cleaner expansion of signaling features.