Skip to content

Commit

Permalink
Add latest versions to Travis, support 1.10+ only (#35)
Browse files Browse the repository at this point in the history
  • Loading branch information
prashantv committed Aug 23, 2019
1 parent 3b01965 commit 227bd74
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 9 deletions.
10 changes: 4 additions & 6 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,17 +3,15 @@ language: go
go_import_path: go.uber.org/goleak

go:
# TODO(prashant): Enable once we have fixed Linux issues with old versions.
#- 1.6
#- 1.7
#- 1.8
- 1.9.2
- 1.10.x
- 1.11.x
- 1.12.x
env:
- TEST=yes

matrix:
include:
- go: 1.9.2
- go: 1.12.x
env: COVERAGE=yes LINT=yes

cache:
Expand Down
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 +19,15 @@ test:

.PHONY: install_lint
install_lint:
go get github.com/golang/lint/golint
go get golang.org/x/lint/golint

.PHONY: lint
lint:
@rm -rf lint.log
@echo "Checking formatting..."
@gofmt -d -s $(PACKAGE_FILES) 2>&1 | tee lint.log
@echo "Checking vet..."
@$(foreach dir,$(PACKAGE_FILES),go tool vet $(dir) 2>&1 | tee -a lint.log;)
@go vet $(PACKAGES) 2>&1 | tee -a lint.log
@echo "Checking lint..."
@$(foreach dir,$(PACKAGES),golint $(dir) 2>&1 | tee -a lint.log;)
@echo "Checking for unresolved FIXMEs..."
Expand Down
2 changes: 1 addition & 1 deletion leaks_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ type fakeT struct {
}

func (ft *fakeT) Error(args ...interface{}) {
ft.errors = append(ft.errors, fmt.Sprint(args))
ft.errors = append(ft.errors, fmt.Sprint(args...))
}

func TestVerifyNone(t *testing.T) {
Expand Down

0 comments on commit 227bd74

Please sign in to comment.