This repository has been archived by the owner on Oct 2, 2020. It is now read-only.
Refactor fieldHook function #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willhug
force-pushed
the
structRecurse-part_2.0
branch
from
7ef1471
to
eae9931
Compare
Summary: I was having a hard time reasoning about the fieldHook function so I did some refactoring to make it easier to add the embedded struct fields. - Remove the in-place data value updates (this appears to have been an optimization, but, it's not necessary and make the code hard to reason about) - Extract getting the updates struct into it's own function. - Extract getting decodable Struct fields into it's own function. - Extract applying updates to the srcData into it's own function. - Rename variables to be more explicit - Don't use the `from` field, which should be equivalent to srcData.Type() Test Plan: tests pass
willhug
force-pushed
the
structRecurse-part_2.0
branch
from
eae9931
to
8b7bb8e
Compare
|
IMO this and #18 can be deleted if you just implement field hooks in mapstructure rather than implementing them as a decode hook. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: I was having a hard time reasoning about the fieldHook function
so I did some refactoring to make it easier to add the embedded struct
fields.
optimization, but, it's not necessary and make the code hard to reason
about)
fromfield, which should be equivalent tosrcData.Type()
Test Plan: tests pass
#15