Drop external atomic dependency #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that this package only supports Go 1.19 and 1.20, it can make use of the atomic.Bool [1] added in Go 1.19. [1] https://pkg.go.dev/sync/atomic#Bool This has the effect of eliminating any external dependencies from this package -- minus testify, which is only used for testing.
Codecov Report
@@ Coverage Diff @@
## master #72 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 110 110
=========================================
Hits 110 110
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
abhinav
added a commit
to abhinav/multierr
that referenced
this pull request
Feb 15, 2023
Will be true when uber-go#72 lands.
prashantv
approved these changes
Feb 15, 2023
sywhang
approved these changes
Feb 15, 2023
abhinav
added a commit
to uber-go/zap
that referenced
this pull request
Mar 19, 2023
Switches all uses of go.uber.org/atomic to types defined in sync/atomic. These types have been available since Go 1.19, which is the minimum supported version of Go for Zap. This allows us to drop one dependency from Zap. The version of multierr was bumped to pick up uber-go/multierr#72 which made a similar change to that package. This was nearly a drop-in, save the following: - There's no `Int*.Inc`; we have to use `Int*.Add(1)` - There's no `Bool.Toggle`; we have to implement the CAS loop manually
abhinav
added a commit
to abhinav/cff
that referenced
this pull request
Oct 28, 2023
Replace uses of go.uber.org/atomic with the standard library's sync/atomic. On top of that, upgrade to the latest release of multierr to pull in uber-go/multierr#72 which made a similar change there. With these two changes combined, drop the dependency on go.uber.org/atomic completely.
sywhang
added a commit
to uber-go/cff
that referenced
this pull request
Oct 28, 2023
Replace uses of go.uber.org/atomic with the standard library's sync/atomic. On top of that, upgrade to the latest release of multierr to pull in uber-go/multierr#72 which made a similar change there. With these two changes combined, drop the dependency on go.uber.org/atomic completely. (Won't pass lint until #59 merges.) Co-authored-by: Sung Yoon Whang <sungyoonwhang@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that this package only supports Go 1.19 and 1.20,
it can make use of the atomic.Bool [1] added in Go 1.19.
[1] https://pkg.go.dev/sync/atomic#Bool
This has the effect of eliminating any external dependencies
from this package -- minus testify, which is only used for testing.