Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a comment on timers on windows #82

Merged
merged 2 commits into from
Mar 31, 2022
Merged

Add a comment on timers on windows #82

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3debc4b
Add a comment on timers on windows
rabbbit Mar 31, 2022
aeba813
whitespace
rabbbit Mar 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,10 @@ func main() {
- What's the major diff v.s. https://pkg.go.dev/golang.org/x/time/rate? (based on #77)

This ratelimiter was meant to have a (1) simple API and (2) minimal overheard. For more complex use-cases [x/time/rate] is a great choice. See [here][redit] for historical context, and [here][bench] for benchmarks (from 2016).

- Why does example_test.go fail when I run it locally on Windows? (based on #80)

Windows has some known issues with timers precision. See golang/go#44343. We don't expect to work around it.

[cov-img]: https://codecov.io/gh/uber-go/ratelimit/branch/master/graph/badge.svg?token=zhLeUjjrm2
[cov]: https://codecov.io/gh/uber-go/ratelimit
Expand Down