Add example that shows how to log to a file #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -54,6 +55,35 @@ func Example() { | |||
| // {"msg":"Oh no!","level":"error","ts":0,"fields":{"user":"jane@test.com","visits":42}} | |||
| } | |||
|
|
|||
| func Example_fileOutput() { | |||
| // Create a temporary file to output logs to. | |||
| f, err := ioutil.TempFile("", "log") | |||
There was a problem hiding this comment.
Don't you need to delete the file after you're done?
There was a problem hiding this comment.
Good point, added a defer os.Remove(...)
prashantv
force-pushed
the
pv_fileexample
branch
from
87ea222
to
d522221
Compare
|
LGTM |
|
|
||
| logger.Info("This is an info log.", zap.Int("foo", 42)) | ||
|
|
||
| // Sync the file so logs are written to disk, and print the file contents. |
There was a problem hiding this comment.
If we're including this in an example, can we call out that zap already syncs when logging at PanicLevel and FatalLevel?
prashantv
force-pushed
the
pv_fileexample
branch
from
d522221
to
747abfb
Compare
|
|
| } | ||
| defer os.Remove(f.Name()) | ||
|
|
||
| logger := zap.NewJSON( |
There was a problem hiding this comment.
zap do not have NewJSON method?
what should I do?
|
@MonsieurHorse let's discuss this on the issue you opened. This PR is very old, and APIs have changed quite a bit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #100