Refactor Encoder.WriteEntry => Encoder.EncodeEntry #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jcorbin, thanks for your PR! By analyzing the history of the files in this pull request, we identified @akshayjshah and @prashantv to be potential reviewers. |
akshayjshah
suggested changes
Jan 12, 2017
| @@ -113,7 +113,7 @@ func TestWriterFacilitySyncsOutput(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| func TestWriterFacilityWriteEntryFailure(t *testing.T) { | |||
There was a problem hiding this comment.
Can we add another test case here with the short writer from the testutils package?
| } | ||
|
|
||
| final := jsonPool.Get().(*jsonEncoder) | ||
| final.truncate() | ||
| final.bytes = append(final.bytes, '{') | ||
| enc.LevelFormatter(ent.Level).AddTo(final) | ||
| enc.TimeFormatter(ent.Time).AddTo(final) |
There was a problem hiding this comment.
Just for sanity, we should probably use final.LevelFormatter. Same for the time and message formatters.
akshayjshah
reviewed
Jan 13, 2017
| func TestWriterFacilityShortWrite(t *testing.T) { | ||
| fac := WriterFacility( | ||
| NewJSONEncoder(testJSONConfig()), | ||
| Lock(AddSync(&testutils.ShortWriter{})), |
There was a problem hiding this comment.
Separate note: we don't need the the AddSync anymore.
jcorbin
force-pushed
the
jcorbin.functional_encoder
branch
from
7fe5b84
to
92dbcaa
Compare
akshayjshah
approved these changes
Jan 13, 2017
akshayjshah
pushed a commit
that referenced
this pull request
Feb 15, 2017
* Refactor Encoder.{Write => Encode}Entry
* Just use final in jsonEncoder.EncodeEntry
* Add a short write test
* Fix dat package
* Drop AddSync from TestWriterFacility*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encoders should, well, encode. Writing to a sink is a concern for the facility.