remove WriteSyncer's automatic lock #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok, the same question as in #359. When will this be merged? :) |
|
Thanks for opening a second PR! This goes further than what I'd intended; I'm going to push a commit to back out some of these changes. |
akshayjshah
force-pushed
the
remove-lock
branch
from
1474f21
to
f2a590e
Compare
akshayjshah
approved these changes
Mar 13, 2017
writer.go
Outdated
| @@ -81,5 +81,5 @@ func CombineWriteSyncers(writers ...zapcore.WriteSyncer) zapcore.WriteSyncer { | |||
| if len(writers) == 0 { | |||
| return zapcore.AddSync(ioutil.Discard) | |||
| } | |||
| return zapcore.Lock(zapcore.NewMultiWriteSyncer(writers...)) | |||
There was a problem hiding this comment.
I'd prefer to keep this auto-lock, since it lets users easily replicate the behavior of the Config struct. In general, I'd like the zapcore package to have no defaults and the zap package to supply sane defaults.
Anyone who doesn't want this auto-locking can just use zapcore.NewMultiWriteSyncer.
options.go
Outdated
| @@ -63,7 +63,7 @@ func Fields(fs ...zapcore.Field) Option { | |||
| // safe for concurrent use. | |||
There was a problem hiding this comment.
Need to update the comment here.
The lock goes up to function call to make changes compatible. And now, it's user's duty to make WriteSyncer concurrent-safe.
akshayjshah
force-pushed
the
remove-lock
branch
from
f2a590e
to
35bc23e
Compare
prashantv
approved these changes
Mar 13, 2017
bufdev
approved these changes
Mar 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lock goes up to function call to make changes compatible.
And now, it's user's duty to make
WriteSyncerconcurrent-safe.Fix up #359.