Add MarshalText to AtomicLevel and FilterMessageSnippet to observer #413
Conversation
There was a problem hiding this comment.
Can we break this up into separate PRs since the MarshalText and observer changes look unrelated.
Regarding MarshalText, I'm not sure why it is on the pointer. Since functions like Enabled are on the value receiver, I'd expect MarshalText to also be on the value receiver. UnmarshalText modifies the underlying value so it must be on a pointer receiver, but the other methods shouldn't need to use pointers.
The same issue exists with Level currently, I'll send out a separate PR to change it to value receiver where we can discuss this a little more.
|
It was definitely awkward working with the pointer receiver there, thanks for the PR. I'll break this up. |
|
I'm closing this so that the two parts can be merged from sane branch names in my fork. |
My team displays its yaml configs on HTML debug pages and thus requires that AtomicLevel support marshalling.
Additionally, we are currently transitioning from logrus style format logging to zap.SugaredLogger and use a testing strategy where we assert that a log message contains some list of snippets, rather than asserting on the entire formatted log message. This seems generally useful for users of the SugaredLogger.