zapcore.Level: Move MarshalText to value receiver #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, MarshalText and UnmarshalText are both using pointer receivers but only UnmarshalText needs a pointer receiver since it mutates the underlying value. MarshalText should be on the same receiver type as String. On the other hand, UnmarshalText requires a pointer receiver, and it can handle the case where we try to unmarshal to a nil pointer.
billf
approved these changes
Apr 21, 2017
akshayjshah
approved these changes
Apr 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, MarshalText and UnmarshalText are both using pointer
receivers but only UnmarshalText needs a pointer receiver since it
mutates the underlying value.
MarshalText should be on the same receiver type as String. On the other
hand, UnmarshalText requires a pointer receiver, and it can handle the
case where we try to unmarshal to a nil pointer.
cc @ZymoticB