Add FAQ question on zap dropping logs due to sampling #875
+7
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #875 +/- ##
==========================================
- Coverage 98.36% 98.21% -0.16%
==========================================
Files 43 43
Lines 2390 1904 -486
==========================================
- Hits 2351 1870 -481
+ Misses 32 27 -5
Partials 7 7
Continue to review full report at Codecov.
|
rabbbit
approved these changes
Nov 12, 2020
|
Is coverage expected to be off? |
Looks like it fixed itself, now says no coverage differences. Not sure what was going on earlier |
cgxxv
pushed a commit
to cgxxv/zap
that referenced
this pull request
Mar 25, 2022
Multiple issues have been opened about missing logs (e.g., uber-go#874, uber-go#588). While sampling is mentioned in the API documentation for `NewProductionConfig`, it may help to add an FAQ question as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple issues have been opened about missing logs (e.g., #874, #588).
While sampling is mentioned in the API documentation for
NewProductionConfig,it may help to add an FAQ question as well.