Make Stats class accept stats in constructor #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibgreen
approved these changes
Aug 25, 2019
docs/api-reference/log/stats.md
Outdated
|
|
||
| * `id` (`String`) - the id of the `Stats` object. | ||
| * `stats` (`String`) - the list of stats. Each element in the stats could be either`Stat` object or `{id, type}` (type is optional, default is `count`); |
There was a problem hiding this comment.
Nit: stats type: String[] | Object[] or (String | Object)[]
An alternative is to make type an Object map with ids as keys. This way we could separating id (easy to use in code) from name (being a printable, human readable name to use in the stats widget).
new Stats({
id,
stats: {
count: {name: 'Count', type: 'count', resetOnUpdate: true}
}
});There was a problem hiding this comment.
will do another PR to resolve this
| @@ -154,7 +154,7 @@ export default class StatsWidget { | |||
| } | |||
|
|
|||
| _createDOMStats() { | |||
| if (this.stats && this.stats.size) { | |||
| if (this.stats instanceof Stats) { | |||
There was a problem hiding this comment.
stats could be empty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.