Lint Lenient Mode for captured Disposable #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZacSweers
reviewed
Dec 5, 2018
|
It does. I can add a test case. |
ZacSweers
reviewed
Dec 6, 2018
...alysis/autodispose-lint/src/test/kotlin/com/uber/autodispose/lint/AutoDisposeDetectorTest.kt
Outdated
Show resolved
Hide resolved
ZacSweers
reviewed
Dec 10, 2018
| ) { | ||
| context.report(ISSUE, node, context.getLocation(node), LINT_DESCRIPTION) | ||
| val isUnusedReturnValue = isExpressionValueUnused(node) | ||
| if (isUnusedReturnValue || !isCapturedTypeAllowed(node.returnType, method)) { |
There was a problem hiding this comment.
Can you add a test for method references? Both in java and kotlin
There was a problem hiding this comment.
That was a good catch, thanks!
443573d
ZacSweers
approved these changes
Dec 12, 2018
ShaishavGandhi
force-pushed
the
sg/lenient-lint
branch
from
52f674a
to
3821088
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This checks if the returned
Disposableis handled by the user and doesn't raise errors in that case. We assume that you know what you're doing with it.Resolves #295