Make error-prone checker add custom scopes to default scopes #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaishavGandhi
commented
Dec 6, 2018
...is/autodispose-error-prone/src/main/java/com/uber/autodispose/errorprone/UseAutoDispose.java
Outdated
Show resolved
Hide resolved
ZacSweers
reviewed
Dec 6, 2018
...is/autodispose-error-prone/src/main/java/com/uber/autodispose/errorprone/UseAutoDispose.java
Outdated
Show resolved
Hide resolved
...is/autodispose-error-prone/src/main/java/com/uber/autodispose/errorprone/UseAutoDispose.java
Outdated
Show resolved
Hide resolved
...is/autodispose-error-prone/src/main/java/com/uber/autodispose/errorprone/UseAutoDispose.java
Outdated
Show resolved
Hide resolved
...is/autodispose-error-prone/src/main/java/com/uber/autodispose/errorprone/UseAutoDispose.java
Outdated
Show resolved
Hide resolved
...is/autodispose-error-prone/src/main/java/com/uber/autodispose/errorprone/UseAutoDispose.java
Outdated
Show resolved
Hide resolved
...is/autodispose-error-prone/src/main/java/com/uber/autodispose/errorprone/UseAutoDispose.java
Outdated
Show resolved
Hide resolved
.../src/test/resources/com/uber/autodispose/errorprone/UseAutoDisposeNegativeCasesExcluded.java
Outdated
Show resolved
Hide resolved
|
This suggestion thing is stupid. Doesn't let me batch changes 🙄 |
|
No need to batch, separate commits is better for readability |
Co-Authored-By: shaishavgandhi05 <shaishgandhi@gmail.com>
ShaishavGandhi
force-pushed
the
sg/additive-scopes-ep
branch
from
e30ac93
to
cce7b8f
Compare
ZacSweers
approved these changes
Dec 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new flag
isScopeExclusive(open to suggestions) that will make the classes supplied inTypesWithScopeexclusive and will only perform the check on those classes.In the absence of that flag, we will add the custom scope classes to the
DEFAULT_CLASSES_WITH_LIFECYCLEinstead of ignoring the default ones.Part of #298