Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make types with scope additive by default, add flag to make it exclusive #298

Closed
1 of 2 tasks
ZacSweers opened this issue Dec 3, 2018 · 2 comments
Closed
1 of 2 tasks

Make types with scope additive by default, add flag to make it exclusive #298

ZacSweers opened this issue Dec 3, 2018 · 2 comments
Labels
Enhancement Static analysis
Milestone
1.1.0

Comments

@ZacSweers
Copy link
Collaborator

ZacSweers commented Dec 3, 2018 •
edited

I suspect most people just want to add custom scopes

  • Lint
  • Error Prone
@ShaishavGandhi
Copy link
Collaborator

Scopes are added to the default Android ones in lint already.

@ZacSweers
Copy link
Collaborator Author

oh neat, then it just needs an exclusive flag

@ShaishavGandhi ShaishavGandhi mentioned this issue Dec 6, 2018
Merged
ZacSweers pushed a commit that referenced this issue Dec 7, 2018
@ShaishavGandhi @ZacSweers
Make error-prone checker add custom scopes to default scopes (#308)
1456c73 
This adds a new flag `isScopeExclusive` (open to suggestions) that will make the classes supplied in `TypesWithScope` exclusive and will only perform the check on those classes. 

In the absence of that flag, we will *add* the custom scope classes to the `DEFAULT_CLASSES_WITH_LIFECYCLE` instead of ignoring the default ones. 

Part of #298
@ShaishavGandhi ShaishavGandhi mentioned this issue Dec 12, 2018
Merged
@ZacSweers ZacSweers added this to the 1.1.0 milestone Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement Static analysis
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
2 participants
@ZacSweers @ShaishavGandhi