Add overrideScopes flag to lint check #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZacSweers
approved these changes
Dec 12, 2018
...c-analysis/autodispose-lint/src/main/kotlin/com/uber/autodispose/lint/AutoDisposeDetector.kt
Outdated
Show resolved
Hide resolved
| properties.property(OVERRIDE_SCOPES, "true") | ||
| properties.to(AutoDisposeDetector.PROPERTY_FILE) | ||
|
|
||
| lint().files(rxJava2(), LIFECYCLE_OWNER, ACTIVITY, properties, kotlin(""" |
There was a problem hiding this comment.
nit - for readability, please put each of these args starting on separate lines
There was a problem hiding this comment.
Have changed it for the two methods I added but the remaining ones still have it. Can do another PR for those to clean up the formatting there. On a side note, should we think about a checkstyle to enforce conventions?
There was a problem hiding this comment.
cleaning up the rest separately is fine. There's an open issue for code style #154, but in general try to match what the rest of the project does too. My goal would be to use something like spotless
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an
overrideScopesflag that would exclude the default scopes in the lint check.Resolves #298