Add module for RxLifecycle3 Interop #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZacSweers
approved these changes
Dec 18, 2018
...pose-rxlifecycle3/src/main/java/com/ubercab/autodispose/rxlifecycle3/RxLifecycleInterop.java
Outdated
Show resolved
Hide resolved
|
@hzsweers Ok with renaming |
|
Ah sorry missed that. Let's leave it, we can make a comment about the
version jump in the changelog. Renaming the artifact would render it a
different artifact that people have to point to.
…On Mon, Dec 17, 2018 at 10:15 PM Shaishav Gandhi ***@***.***> wrote:
@hzsweers <https://github.com/hzsweers> Ok with renaming
autodispose-rxlifecycle to autodispose-rxlifecycle2?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#319 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABTEviF0Qr6OnqNdEbLv3amoeQxsX4joks5u6IgDgaJpZM4ZXpCr>
.
|
|
Oops should have been clearer. I meant the gradle module name and not the artifact name itself. But i get it if we want to leave it to keep artifact and gradle module names the same. |
|
Let's keep the Gradle module name the same as well to match convention
…On Mon, Dec 17, 2018 at 10:19 PM Shaishav Gandhi ***@***.***> wrote:
Oops should have been clearer. I meant the gradle module name and not the
artifact name itself. But i get it if we want to leave it to keep artifact
and gradle module names the same.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#319 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABTEvvhyjKJtKjsAPcJiN_IU-aGzm1fhks5u6Ij2gaJpZM4ZXpCr>
.
|
|
Should add an entry to the README as well
…On Mon, Dec 17, 2018 at 11:12 PM Shaishav Gandhi ***@***.***> wrote:
Merged #319 <#319> into master.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#319 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABTEvi5t4dK5eY9naCwF1tGzx0emdVrSks5u6JVigaJpZM4ZXpCr>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #318, this adds a new module for RxLifecycle3 interop. It's basically copy-pasta from
autodispose-rxlifecyclewith package change.We can also change the name of
autodispose-rxlifecycletoautodispose-rxlifecycle2?