Assertion of not equal to null updates the access path #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
msridhar
requested changes
Oct 10, 2018
nullaway/src/main/java/com/uber/nullaway/dataflow/AccessPathNullnessPropagation.java
Show resolved
Hide resolved
| @@ -114,7 +114,7 @@ public ControlFlowGraph load(CfgParams key) { | |||
| codePath.getLeaf(), (ClassTree) codePath.getParentPath().getLeaf()); | |||
| bodyPath = codePath; | |||
| } | |||
| return CFGBuilder.build(bodyPath, ast, false, false, env); | |||
| return CFGBuilder.build(bodyPath, ast, true, false, env); | |||
There was a problem hiding this comment.
I thought we agreed that there would be a command-line flag controlling whether we treat assertions as being on or not?
msridhar
requested changes
Oct 12, 2018
| @@ -63,6 +63,8 @@ | |||
| */ | |||
| private static final int MAX_CACHE_SIZE = 50; | |||
|
|
|||
| private boolean assertsEnabled; | |||
There was a problem hiding this comment.
Let's make this final, initialize in the constructor, and get rid of the setAssertionsEnabled() method
|
Thanks for the contribution @shas19! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for assert statements that check if the left operand is not equal to null. It will be assumed that the operand is NONNULL, and warnings will change accordingly.
Fixes #122
Added unit tests