-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for nullable type upper bounds considering Library mod… #893
Closed
Closed
Changes from 19 commits
Commits
Show all changes
94 commits
Select commit
Hold shift + click to select a range
f71df65
Adding support for nullable type upper bounds considering Library mod…
akulk022 e27b474
Adding implementation for nullableVariableTypeUpperBounds method
akulk022 529a26b
Adding method onOverrideTypeParameterUpperBound to Handler Interface …
akulk022 f10c491
Updating java docs
akulk022 b122a66
updating variable name and removing redundant variable
akulk022 50578d7
Update nullaway/src/main/java/com/uber/nullaway/handlers/Handler.java
akulk022 273a959
updating var name and documentation
akulk022 88a4799
Merge remote-tracking branch 'origin/library_models_Function_abhijitk…
akulk022 7849690
Merge branch 'master' into library_models_Function_abhijitk7
akulk022 ce9609c
using putAll instead of loop
akulk022 b56733a
adding positive test case
akulk022 81f8b7d
Adding EmptyLibraryModels abstract class for LibraryModels interface
akulk022 488f005
Revert "Adding EmptyLibraryModels abstract class for LibraryModels in…
akulk022 2634b16
Adding documentation for onOverrideTypeParameterUpperBound in Composi…
akulk022 2730d2a
Adding default implementations for typeVariablesWithNullableUpperBoun…
akulk022 ec115af
Update nullaway/src/main/java/com/uber/nullaway/handlers/LibraryModel…
akulk022 f72959f
Removing redundant default implementations from ExampleLibraryModels …
akulk022 3e0fb0b
Removing positive test case and incorrect java.util.Map library model
akulk022 ee15c59
documentation improvements
msridhar f7462aa
Adding support for nullable type upper bounds considering Library mod…
akulk022 2ee3522
Adding implementation for nullableVariableTypeUpperBounds method
akulk022 8699e85
Adding method onOverrideTypeParameterUpperBound to Handler Interface …
akulk022 ae62aaa
Updating java docs
akulk022 c3eb477
updating variable name and removing redundant variable
akulk022 c3e17cf
updating var name and documentation
akulk022 107d40c
Update nullaway/src/main/java/com/uber/nullaway/handlers/Handler.java
akulk022 e80e35f
using putAll instead of loop
akulk022 0cfd0e2
adding positive test case
akulk022 dc1af63
Adding EmptyLibraryModels abstract class for LibraryModels interface
akulk022 e4d5813
Revert "Adding EmptyLibraryModels abstract class for LibraryModels in…
akulk022 3bf421d
Adding documentation for onOverrideTypeParameterUpperBound in Composi…
akulk022 334af66
Adding default implementations for typeVariablesWithNullableUpperBoun…
akulk022 20f3fe1
Update nullaway/src/main/java/com/uber/nullaway/handlers/LibraryModel…
akulk022 2453b08
Removing redundant default implementations from ExampleLibraryModels …
akulk022 c70ec1d
Removing positive test case and incorrect java.util.Map library model
akulk022 84247a2
library models for nullmarked classes
akulk022 ac94e7a
Merge remote-tracking branch 'origin/library_models_Function_abhijitk…
akulk022 6b92af4
updating isAnnotatedTopLevelClass
akulk022 27918ff
bug fix, still more to do
msridhar 026970c
more fixes, still needs cleanup
msridhar 4e829d7
Updating javadoc for nullMarkedClasses
akulk022 b94597a
Fix bug with implicit equals() methods in interfaces (#898)
msridhar 091ac38
Fix crash with raw types in overrides in JSpecify mode (#899)
msridhar 115d683
Update instructions for Android and our sample app (#900)
msridhar 373917e
docs
msridhar 986d060
Prepare for release 0.10.22.
yuxincs 00a317a
Prepare next development version.
yuxincs 35eac21
Adding support for nullable type upper bounds considering Library mod…
akulk022 71cecb4
Adding implementation for nullableVariableTypeUpperBounds method
akulk022 18a0c6d
Adding method onOverrideTypeParameterUpperBound to Handler Interface …
akulk022 1f28ff5
Updating java docs
akulk022 c911842
updating variable name and removing redundant variable
akulk022 9aea517
updating var name and documentation
akulk022 ba88839
Update nullaway/src/main/java/com/uber/nullaway/handlers/Handler.java
akulk022 75436eb
using putAll instead of loop
akulk022 865873e
adding positive test case
akulk022 91a12f4
Adding EmptyLibraryModels abstract class for LibraryModels interface
akulk022 db16c7a
Revert "Adding EmptyLibraryModels abstract class for LibraryModels in…
akulk022 836ff44
Adding documentation for onOverrideTypeParameterUpperBound in Composi…
akulk022 6a9d7c1
Adding default implementations for typeVariablesWithNullableUpperBoun…
akulk022 cea3614
Update nullaway/src/main/java/com/uber/nullaway/handlers/LibraryModel…
akulk022 7bf7497
Removing redundant default implementations from ExampleLibraryModels …
akulk022 37c7cb0
Removing positive test case and incorrect java.util.Map library model
akulk022 26c82dd
library models for nullmarked classes
akulk022 cd0e659
Adding support for nullable type upper bounds considering Library mod…
akulk022 1bf78df
Adding implementation for nullableVariableTypeUpperBounds method
akulk022 268022a
Adding method onOverrideTypeParameterUpperBound to Handler Interface …
akulk022 5e5df6a
Updating java docs
akulk022 6c24cbd
updating variable name and removing redundant variable
akulk022 32f84ac
updating var name and documentation
akulk022 5f6d9a8
using putAll instead of loop
akulk022 dcc1507
adding positive test case
akulk022 4bba915
Adding EmptyLibraryModels abstract class for LibraryModels interface
akulk022 d24e9c5
Revert "Adding EmptyLibraryModels abstract class for LibraryModels in…
akulk022 2ba7932
Adding default implementations for typeVariablesWithNullableUpperBoun…
akulk022 2ea0b77
Removing redundant default implementations from ExampleLibraryModels …
akulk022 1c1316d
Removing positive test case and incorrect java.util.Map library model
akulk022 924396c
documentation improvements
msridhar 24d5ed0
updating isAnnotatedTopLevelClass
akulk022 0de4d12
bug fix, still more to do
msridhar 32aef72
more fixes, still needs cleanup
msridhar 2acffb3
docs
msridhar e1e23d1
handler updates
akulk022 fb23172
handler updates
akulk022 bc0edd1
Merge remote-tracking branch 'origin/library_models_Function_abhijitk…
akulk022 2dd0ca6
fixes
akulk022 badfd16
updating docs
akulk022 6fc4337
fixes
akulk022 c97e8dc
Merge remote-tracking branch 'origin/library_models_Function_abhijitk…
akulk022 05fe856
Revert "Prepare next development version."
akulk022 37a2008
Revert "Prepare for release 0.10.22."
akulk022 57a2116
Revert "Update instructions for Android and our sample app (#900)"
akulk022 e2beddc
Revert "Fix crash with raw types in overrides in JSpecify mode (#899)"
akulk022 f6996d1
Fix crash with raw types in overrides in JSpecify mode (#899)
msridhar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's write more tests to show the type argument is being handled correctly. E.g., check that passing in
@Nullable
when the first type argument is not@Nullable
yields an error, etc.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment is still not addressed