Add support for target location info #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
collector/collector.go
Outdated
| strings.Repeat("-", 13) + "\n") | ||
| } else { | ||
| logger.Info("Arachne -- Table of Results", | ||
| zap.String("version", defines.ArachneVersion), | ||
| zap.String("hostname", gl.RemoteConfig.HostName), | ||
| zap.String("location", gl.RemoteConfig.Location), |
There was a problem hiding this comment.
Using "location" here, and "target_location" in the metrics tags don't match
There was a problem hiding this comment.
This is the agent's location. Not the target location
collector/collector.go
Outdated
| @@ -517,7 +530,8 @@ func printTableEntry( | |||
|
|
|||
| if !foreground { | |||
| logger.Info("Result", | |||
| zap.String("host", targetHost), | |||
| zap.String("target", targetHost), | |||
| zap.String("location", targetLocation), | |||
There was a problem hiding this comment.
Same comment as above. In metrics tags this is called target_location
There was a problem hiding this comment.
I used target_location in the metrics to differentiate this from the uploading agent's location tag. This is implied to be the target location. I can still rename it though to target_location.
henridevieux
approved these changes
Jul 11, 2017
henridevieux
pushed a commit
that referenced
this pull request
Jul 18, 2017
* Add support for location info to targets * Print out target location info
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to enhancement issue: #27
Before opening your pull request, please make sure that you have:
make test); and finally,make lint).Thanks for your contribution!