schema validation update for array type #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
voyager-dw
requested review from
jshencode,
lxning and
shz117
as code owners
Codecov Report
@@ Coverage Diff @@
## master #310 +/- ##
==========================================
+ Coverage 71.84% 71.91% +0.06%
==========================================
Files 166 166
Lines 23367 23391 +24
==========================================
+ Hits 16789 16822 +33
+ Misses 5285 5273 -12
- Partials 1293 1296 +3
Continue to review full report at Codecov.
|
shz117
reviewed
Oct 1, 2019
shz117
reviewed
Oct 1, 2019
shz117
reviewed
Oct 2, 2019
| @@ -161,6 +165,10 @@ func (v tableSchemaValidatorImpl) validateIndividualSchema(table *common.Table, | |||
| if colIdDedup[sortColumnId] { | |||
| return common.ErrDuplicatedColumn | |||
| } | |||
| colDataType := memCom.DataTypeFromString(table.Columns[sortColumnId].Type) | |||
| if colDataType >= memCom.ArrayBool && colDataType <= memCom.ArrayInt64 { | |||
There was a problem hiding this comment.
memCom.IsArrayType(colDataType)
shz117
approved these changes
Oct 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.