Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): fix types of event handlers #1915 #1924

Merged
merged 1 commit into from
Sep 19, 2019

Conversation

choyongjoon
Copy link
Contributor

Fixes #1915

Description

Search all cases in all index.d.ts files through this regex:

event: React\.(.*)EventHandler

and replace with this regex:

event: React.$1Event

Scope

  • Patch: Bug Fix
  • Minor: New Feature
  • Major: Breaking Change

@CLAassistant
Copy link

CLAassistant commented Sep 19, 2019

CLA assistant check
All committers have signed the CLA.

@gergelyke gergelyke merged commit 997ab98 into uber:master Sep 19, 2019
Copy link
Contributor

@restrin-extensis restrin-extensis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ButtonProps, too.

onClick?: (event: React.MouseEventHandler<HTMLButtonElement>) => any;

@restrin-extensis restrin-extensis mentioned this pull request Sep 23, 2019
3 tasks
VladimirMilenko pushed a commit to VladimirMilenko/baseui that referenced this pull request Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Types of some event props are not correct
6 participants