fix(menu): improve for screen reader compatibility #2950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chasestarr
requested review from
gergelyke,
nadiia,
sandgraham and
tajo
as code owners
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/uber-ui-platform/baseweb/iq5wfpsv0 |
gergelyke
approved these changes
Mar 3, 2020
|
Works wonderfully. |
tajo
approved these changes
Mar 3, 2020
cbranch101
pushed a commit
to cbranch101/baseweb
that referenced
this pull request
Mar 26, 2020
* fix(menu): tell screenreader menu item is disabled * feat(menu): add activedescendant change handler * fix(select): apply active descendant to select input * fix(select): apply listbox id to input controls * fix(select): applies aria label with selected values * fix(menu): update menu tests * fix(select): conditionally apply listbox id * fix(select): update snapshot * fix(menu): adds message for how to operate child menu * fix(menu): communicate empty state to screen reader
VladimirMilenko
pushed a commit
to VladimirMilenko/baseui
that referenced
this pull request
Apr 2, 2020
* fix(menu): tell screenreader menu item is disabled * feat(menu): add activedescendant change handler * fix(select): apply active descendant to select input * fix(select): apply listbox id to input controls * fix(select): applies aria label with selected values * fix(menu): update menu tests * fix(select): conditionally apply listbox id * fix(select): update snapshot * fix(menu): adds message for how to operate child menu * fix(menu): communicate empty state to screen reader
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describes how to maneuver the child menus and politely updates screen reader with empty state message. Depends on #2947 landing
Scope