fix(button): respect focus handler props #2976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally I was going to update the Popover "hover" trigger to also trigger on focus events. Reading through our docs, I noticed that we already have this feature (under the Accessibility section). Sure enough, we already pass through the focus events to the anchor (or wrapping span). The issue is that Button overwrites any `onFocus` and `onBlur` handlers passed as top level props. It respects overrides for those props but technically people can pass `onFocus` and `onBlur` as top level props so this commit updates the handlers to restore that option.
sandgraham
requested review from
chasestarr,
gergelyke,
nadiia and
tajo
as code owners
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/uber-ui-platform/baseweb/jbsfioycw |
gergelyke
approved these changes
Mar 4, 2020
tajo
approved these changes
Mar 4, 2020
cbranch101
pushed a commit
to cbranch101/baseweb
that referenced
this pull request
Mar 26, 2020
Originally I was going to update the Popover "hover" trigger to also trigger on focus events. Reading through our docs, I noticed that we already have this feature (under the Accessibility section). Sure enough, we already pass through the focus events to the anchor (or wrapping span). The issue is that Button overwrites any `onFocus` and `onBlur` handlers passed as top level props. It respects overrides for those props but technically people can pass `onFocus` and `onBlur` as top level props so this commit updates the handlers to restore that option.
VladimirMilenko
pushed a commit
to VladimirMilenko/baseui
that referenced
this pull request
Apr 2, 2020
Originally I was going to update the Popover "hover" trigger to also trigger on focus events. Reading through our docs, I noticed that we already have this feature (under the Accessibility section). Sure enough, we already pass through the focus events to the anchor (or wrapping span). The issue is that Button overwrites any `onFocus` and `onBlur` handlers passed as top level props. It respects overrides for those props but technically people can pass `onFocus` and `onBlur` as top level props so this commit updates the handlers to restore that option.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally I was going to update the Popover "hover" trigger to also
trigger on focus events. Reading through our docs, I noticed that we
already have this feature (under the Accessibility section). Sure
enough, we already pass through the focus events to the anchor (or
wrapping span).
The issue is that Button overwrites any
onFocusandonBlurhandlerspassed as top level props. It respects overrides for those props but
technically people can pass
onFocusandonBluras top level propsso this commit updates the handlers to restore that option.