Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test): fail unit tests of console warn/error #3819

Merged
merged 3 commits into from
Oct 8, 2020

Conversation

chasestarr
Copy link
Collaborator

Closes: https://github.com/uber/baseweb/issues/2980

After this change, unit-tests will fail if an unexpected console.warn or console.error is called. This will help to avoid publishing known errors to users

@vercel
Copy link

vercel bot commented Oct 8, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/uber-ui-platform/baseweb/isjxiqjcx
✅ Preview: https://baseweb-git-fail-unit-tests-on-error-warn.uber-ui-platform.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 8, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit bf09043:

Sandbox Source
Basic usage Configuration
Select Issue #2980

@chasestarr chasestarr merged commit d80dea5 into master Oct 8, 2020
@chasestarr chasestarr deleted the fail-unit-tests-on-error-warn branch October 8, 2020 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Select and other components using Menu / MenuStatefulContainer throws warnings
1 participant