chore(button): make button borders rounded #4999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Square and rectangular buttons should have borde radius of 8px
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3ad00ff:
|
Deploying with
|
| Latest commit: |
3ad00ff
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6958287d.baseweb.pages.dev |
| Branch Preview URL: | https://make-button-corners-rounded.baseweb.pages.dev |
|
Visual changes were detected on this branch. Please review the following PR containing updated snapshots: #5000 |
Co-authored-by: UberOpenSourceBot <UberOpenSourceBot@users.noreply.github.com>
tajo
approved these changes
Jun 27, 2022
|
Button group design seems to be affected in a negative way after this change.
Somehow they no longer appear to be a group (especially in the radio mode). Feels like individual buttons. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Square and rectangular buttons should have border radius of 8px
Scope
Patch: Bug Fix