Pass taskListActivitiesPerSecond down to ActivityWorker #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sokada1221 sorry we didn't approve it in time. Can you resolve the conflict? and I will merge it int. The code is moved to SingleWorkerOptions.java, should be pretty straightforward to resolve. |
|
Sure. I'll take a look this weekend. Thanks! |
sokada1221
force-pushed
the
fix-task-list-activities-per-second
branch
from
42eee7a
to
64d0838
Compare
|
@longquanzheng Conflict should be resolved now. PTAL again. Thanks! |
longquanzheng
approved these changes
Dec 12, 2020
|
The test failure will be fixed after #568 see https://github.com/uber/cadence-java-client/pull/572/files |
meiliang86
approved these changes
Jan 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #555
Test results: