Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/upgrade eslint #479

Merged
merged 13 commits into from
Jun 2, 2022
Merged

Feature/upgrade eslint #479

merged 13 commits into from
Jun 2, 2022

Conversation

just-at-uber
Copy link
Contributor

@just-at-uber just-at-uber commented Jun 1, 2022 •
edited

Changed

  • Upgrading eslint library so that lint command can support optional chaining
  • Upgraded eslint vue plugin as the old version has conflict with newer eslint version.
  • Disabled vue/multi-word-component-names as this rule is not needed (introduced from updated eslint vue plugin)
  • Fixed ci ssh issue with eslint-plugin-header

Removed

  • Removed unused eslint plugins. Should have no effect on the lint process (React, React hooks, fusion, flowtype, cup etc.).

@just-at-uber just-at-uber marked this pull request as ready for review June 2, 2022 00:04
@just-at-uber just-at-uber requested a review from a team June 2, 2022 00:04
@just-at-uber just-at-uber merged commit 2b15dc2 into master Jun 2, 2022
@just-at-uber just-at-uber deleted the feature/upgrade-eslint branch June 2, 2022 17:06
@just-at-uber just-at-uber mentioned this pull request Jul 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidporter-id-au davidporter-id-au davidporter-id-au approved these changes

@mkolodezny mkolodezny mkolodezny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@just-at-uber @davidporter-id-au @mkolodezny