Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use gRPC outbound by default for internal traffic #4492

Merged

Conversation

vytautas-karpavicius
Copy link
Contributor

What changed?
Cadence server will use gRPC outbound for internal traffic by default.

User can still opt-out by setting dynamic config system.enableGRPCOutbound to false.
However we should consider TChannel for internal communication deprecated and will work towards removing it in the future.

Why?
Another step in gRPC migration. We have been running gRPC internally for the last few months, it looks stable to be used by default.

How did you test it?

Potential risks

Release notes
Updated changelog.

Documentation Changes

@coveralls
Copy link

coveralls commented Sep 16, 2021

Pull Request Test Coverage Report for Build 2a90ea16-f28d-465a-8d05-f232a2779aba

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 36 unchanged lines in 7 files lost coverage.
  • Overall coverage decreased (-0.008%) to 56.427%

Files with Coverage Reduction New Missed Lines %
common/task/weightedRoundRobinTaskScheduler.go 1 88.6%
client/history/client.go 2 40.74%
client/history/metricClient.go 2 45.94%
service/history/handler.go 2 47.76%
service/frontend/workflowHandler.go 4 58.59%
service/history/historyEngine.go 9 70.24%
common/persistence/sql/sqlExecutionStore.go 16 58.73%
Totals Coverage Status
Change from base Build b8751eb9-3ab1-4d17-b0c7-b3bf73327ab1: -0.008%
Covered Lines: 79951
Relevant Lines: 141689

💛 - Coveralls

@vytautas-karpavicius vytautas-karpavicius marked this pull request as ready for review September 16, 2021 14:49
@vytautas-karpavicius vytautas-karpavicius requested a review from a team September 16, 2021 14:49
@vytautas-karpavicius vytautas-karpavicius merged commit 5846821 into uber:master Sep 17, 2021
@vytautas-karpavicius vytautas-karpavicius deleted the default-grpc-outbound branch September 17, 2021 08:14
github-actions bot pushed a commit to yux0/cadence that referenced this pull request Sep 20, 2021
github-actions bot pushed a commit to yux0/cadence that referenced this pull request Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants